doc/changelog.txt

@@ -10,10 +10,6 @@
 - (fix) sorting same-day batch articles (thanks to @lamescholar for the report)
 - (fix) showing login page in the selected theme (thanks to @feddiriko for the report)
 - (fix) parsing atom feeds with html elements (thanks to @tillcash & @toBeOfUse for the report, @krkk for the fix)
-- (fix) parsing feeds with missing guids (thanks to @hoyii for the report)
-- (fix) sending actual client version to servers (thanks to @aidanholm)
-- (fix) error caused by missing config dir (thanks to @timster)
-- (etc) load external images with no-referrer policy (thanks to @tillcash for the report)
 
 # v2.4 (2023-08-15)
 

src/parser/feed.go

@@ -2,7 +2,6 @@ package parser
 
 import (
 	"bytes"
-	"crypto/sha256"
 	"encoding/xml"
 	"errors"
 	"fmt"
@@ -120,7 +119,6 @@ func ParseAndFix(r io.Reader, baseURL, fallbackEncoding string) (*Feed, error) {
 	}
 	feed.TranslateURLs(baseURL)
 	feed.SetMissingDatesTo(time.Now())
-	feed.SetMissingGUIDs()
 	return feed, nil
 }
 
@@ -170,12 +168,3 @@ func (feed *Feed) TranslateURLs(base string) error {
 	}
 	return nil
 }
-
-func (feed *Feed) SetMissingGUIDs() {
-	for i, item := range feed.Items {
-		if item.GUID == "" {
-			id := strings.Join([]string{item.Title, item.Date.Format(time.RFC3339), item.URL}, ";;")
-			feed.Items[i].GUID = fmt.Sprintf("%x", sha256.Sum256([]byte(id)))
-		}
-	}
-}

src/parser/feed_test.go

@@ -150,32 +150,3 @@ func TestParseCleanIllegalCharsInNonUTF8(t *testing.T) {
 		t.Fatalf("invalid feed, got: %v", feed)
 	}
 }
-
-func TestParseMissingGUID(t *testing.T) {
-	data := `
-		<?xml version="1.0" encoding="windows-1251"?>
-		<rss version="2.0" xmlns:content="http://purl.org/rss/1.0/modules/content/">
-			<channel>
-				<item>
-					<title>foo</title>
-				</item>
-				<item>
-					<title>bar</title>
-				</item>
-			</channel>
-		</rss>
-	`
-	feed, err := ParseAndFix(strings.NewReader(data), "", "")
-	if err != nil {
-		t.Fatal(err)
-	}
-	if len(feed.Items) != 2 {
-		t.Fatalf("expected 2 items, got %d", len(feed.Items))
-	}
-	if feed.Items[0].GUID == "" || feed.Items[1].GUID == "" {
-		t.Fatalf("item GUIDs are missing, got %#v", feed.Items)
-	}
-	if feed.Items[0].GUID == feed.Items[1].GUID {
-		t.Fatalf("item GUIDs are not unique, got %#v", feed.Items)
-	}
-}