From 6222761dd3b6058f6c6a37db76785fcf9d47ffa5 Mon Sep 17 00:00:00 2001 From: Nazar Kanaev Date: Fri, 2 Oct 2020 16:49:34 +0100 Subject: [PATCH] fix favicon fetch bug --- server/crawler.go | 5 ++++- server/server.go | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/server/crawler.go b/server/crawler.go index 69174ef..2ca73e8 100644 --- a/server/crawler.go +++ b/server/crawler.go @@ -158,13 +158,16 @@ func findFavicon(websiteUrl, feedUrl string) (*[]byte, error) { } if len(websiteUrl) != 0 { + base, err := url.Parse(websiteUrl) + if err != nil { + return nil, err + } res, err := defaultClient.get(websiteUrl) if err != nil { return nil, err } defer res.Body.Close() doc, err := goquery.NewDocumentFromReader(res.Body) - base, err := url.Parse(websiteUrl) if err != nil { return nil, err } diff --git a/server/server.go b/server/server.go index 8c21659..c0f32ea 100644 --- a/server/server.go +++ b/server/server.go @@ -83,7 +83,7 @@ func (h *Handler) startJobs() { h.db.UpdateFeedIcon(feed.Id, icon) } if err != nil { - h.log.Print(err) + h.log.Printf("Failed to search favicon for %s (%s): %s", feed.Link, feed.FeedLink, err) } } case <- delTicker.C: