james/yarr
4
0
Fork 0
mirror of https://github.com/nkanaev/yarr.git synced 2025-05-24 00:33:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix iframe autoclosing

Browse Source
This commit is contained in:
Nazar Kanaev 2021-05-13 22:37:02 +01:00
parent 28f08ad42a
commit 37ed856d8b
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/content/sanitizer/sanitizer.go
View File

@ -69,8 +69,12 @@ func Sanitize(baseURL, input string) string {
buffer.WriteString("<" + tagName + ">")
}
if tagName == "iframe" {
// autoclose iframes
buffer.WriteString("</iframe>")
if wrap {
buffer.WriteString("</iframe></div>")
buffer.WriteString("</div>")
}
} else {
tagStack = append(tagStack, tagName)
}
@ -80,6 +84,7 @@ func Sanitize(baseURL, input string) string {
}
case html.EndTagToken:
tagName := token.Data
// iframes are autoclosed. see above
if tagName == "iframe" {
continue
}

10
src/content/sanitizer/sanitizer_test.go
View File

@ -163,6 +163,16 @@ func TestInvalidNestedTag(t *testing.T) {
}
}
func TestValidIFrame(t *testing.T) {
input := `<iframe src="http://example.org/"></iframe>`
expected := `<iframe src="http://example.org/" sandbox="allow-scripts allow-same-origin allow-popups" loading="lazy"></iframe>`
output := Sanitize("http://example.org/", input)
if expected != output {
t.Errorf("Wrong output:\nwant: %s\nhave: %s", expected, output)
}
}
func TestInvalidIFrame(t *testing.T) {
input := `<iframe src="http://example.org/"></iframe>`
expected := ``